Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Brandit #2105

Closed
wants to merge 3 commits into from
Closed

Removed Brandit #2105

wants to merge 3 commits into from

Conversation

Gaardsholt
Copy link

@Gaardsholt Gaardsholt commented Feb 8, 2024

Brandit is now part of Abion which makes the Brandit dns provider useless.
A new pull request for Abion should be created.

@Andrei-Predoiu and @ChristianGroentved can confirm this.

Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
@ldez ldez self-requested a review February 8, 2024 12:19
@ldez
Copy link
Member

ldez commented Feb 8, 2024

Hello,

Even if Brandit is now a part of another company, some current customers can still use this provider.
The API documentation is still available: https://portal.brandit.com/apidocv3

I think you should provide a link to something that says that Brandit API is not usable.

In all cases, the provider will not be removed but deprecated.

@ldez
Copy link
Member

ldez commented Feb 8, 2024

Are you a customer or an employee of Brandit/Abion?
If yes, do you have information about the API?
If yes, are you able to create or test an implementation?

@Gaardsholt
Copy link
Author

I am a customer of Brandit/Abion.
I had a quick look at the API, and it is completely different from the Brandit API, so a re-write of the provider is necessary.

We at least can't use the old API anymore, and it is my understanding that every customer of Brandit has been moved to Abion.

@ldez
Copy link
Member

ldez commented Feb 11, 2024

The Brandit will not be written, we will just deprecate it, and create a new implementation for Abion.

Can you provide a link to the Abion API?
Can you open a new issue?

@Gaardsholt
Copy link
Author

I will see if I can find the API, and I can create the issue if you want me to.
But we are discussing internally if we want to continue using Abion or move it somewhere else.

@ldez
Copy link
Member

ldez commented Feb 12, 2024

If you can find the API doc and open an issue it can be great.

If you find the API doc, maybe I can work with you to create an implementation before you leave Abion.

@Gaardsholt
Copy link
Author

Here you go: #2111

I guess we can go ahead a close this pull request then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants