In HTTP-01, modularize the way of presenting the token.

[yaslama]

First, with a simple local webserver.

[zakjan]

LGTM :)

[mholt]

Should this be exported so users can write their own (if they want to)? I realize users won't need to use the type, but maybe for documentation purposes...

Or if we don't want a user to write their own, then we can leave this unexported, I guess.

[xenolf]

I think we do want the user to be at least be able to write their own.

[yaslama]

The commit 61a0912 fixes that

[xenolf]

This is looking pretty good. But could you fix the tests? :)

[mholt]

For some reason, the word "Webserver" is really bothering me - maybe because it's actually two words. Can we change this to NewHTTPChallengeWebServer instead with a capital S and a capital HTTP?

[yaslama]

In this case, httpChallenge can be renamed to HTTPChallenge if we change it to be exported (like I proposed in my remark to #36) ?

[xenolf]

I'd like to discuss the following change to the HttpChallengeMethod interface

type HttpChallengeSolver interface {
    PresentToken(domain, token, keyAuth string) error
    CleanUp() error
}

This would get rid of the callback to PresentToken and would establish a clear seperation between "challenges" and "solvers".
See this gist for a quick implementation.

[mholt]

^ I support this suggestion. This PR is definitely on the right track, and I think @xenolf's suggestion is a fine way to improve it.

[xenolf]

Any updates on this? :)

[janeczku]

This is a great suggestion.

The task of whoever implements the interface is to provision the validation resource to an HTTP server. I therefore suggest the following naming:

type HttpChallengeProvisioner interface or type HttpChallengeProvider interface

Also maybe pass an identifier to the cleanup method so the provider doesn't have to store the reference to the created resource:

type HttpChallengeProvider interface {
    PresentToken(domain, token, keyAuth string) error
    CleanUp(token) error
}

[jehiah]

@xenolf @yaslama i think you can close this now based on #76