Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

fix: do not omit empty scope list on client grant #29

Merged
merged 1 commit into from Jan 18, 2019

Conversation

mbelang
Copy link
Contributor

@mbelang mbelang commented Jan 14, 2019

The auth0 management requires at least an empty list: https://auth0.com/docs/api/management/v2#!/Client_Grants/post_client_grants

@mbelang mbelang changed the title fix: Do not omit empty scope list on client grant fix: do not omit empty scope list on client grant Jan 14, 2019
@jasonkuhrt
Copy link

IIUC this will fix alexkappa/terraform-provider-auth0#50 (comment). If so, 💯

@mbelang
Copy link
Contributor Author

mbelang commented Jan 17, 2019

@alexkappa Can you review please? :)

@alexkappa
Copy link
Contributor

I've given it a look and I think this is good merged. Normally, removing the omitempty would make it difficult to execute PATCH requests without setting the field (otherwise it will be wiped). But in this case, it seems the schema only allows for the scope field when PATCHing anyway so it makes sense to make this change.

Thanks for giving it a go @mbelang!

@alexkappa alexkappa merged commit 58a4d3f into go-auth0:master Jan 18, 2019
@mbelang mbelang deleted the patch-1 branch January 21, 2019 19:12
@mbelang
Copy link
Contributor Author

mbelang commented Jan 21, 2019

Thanks a lot :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants