-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to pass HCI options when creating a device #28
Conversation
@moogle19 The Travis error is some issue with the script, I think. Could you review this patch? |
The change looks good to me. |
@michal-narajowski |
579bd85
to
83953ac
Compare
@moogle19 Silly of me, I didn't notice the compilation error. Does it look better now? |
Looks good but I think |
This can be useful when we need to use specific HCI device ID.
83953ac
to
2e6b73d
Compare
Changed as requested |
I tested it and it looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any comments to resolve here or we can merge it?
This is ported from go-ble: go-ble/ble#28
This can be useful when we need to use specific HCI device ID.