This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Use SendMessageV2 everywhere #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then rename SendMessageV2 to SendMessage because it does the same thing. This is a breaking change, but it is an easy one to fix, so I want to do it anyway. This isn't necessary everywhere, but for standardization, I thought it would be good to really deprecate SendMessageV1. The place this IS needed is in PeriodicCommands v2 and PassiveCommands V2. In both those places, objects come back from the caller with ProtoParams that should be forwarded through to the message sending.
toolateforteddy
force-pushed
the
useSendV2Everywhere
branch
from
58aafcc
to
fcc799f
Compare
|
@toolateforteddy I agree with deprecated V1. Thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't necessary everywhere, but for standardization, I thought
it would be good to really deprecate SendMessageV1.
The place this IS needed is in PeriodicCommands v2 and PassiveCommands
V2. In both those places, objects come back from the caller with ProtoParams
that should be forwarded through to the message sending.