-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base url use #major #209
base: master
Are you sure you want to change the base?
Base url use #major #209
Conversation
Add a slash to the end of the base url
The option default is false. We will fix the base url by default
Handle chef server URL specification without a trailing / Calculate the URL to use for global endpoint requests Add an option to the configuration to use the URL as specified rather than adding forward slashes and computing the global base. This pull request completes mile stone 1.0. All of the chef server endpoints and methods for chef server 11 are defined. Most have been updated for chef server 12.
This is a breaking change. By default the chef server URL will have a / slash added if none is present. If an organization is specified in the URL the global endpoint will be be computed for the functions that need to address the base chef server URL. |
@mudash @vsingh-msys If you get a moment. Does this one make sense to you? |
@MarkGibbons Looks good to me. The only concern about additional param If we can construct based on b) URL is absolute if passed with forwarding slash "/status", "/association_requests" etc. that would be helpful also global URL looks much similar to
|
@vsingh-msys thanks for the comments. I'll take a look at using the absolute path name for the global requests. I added the UseGlobal and UseOrg to the parameter list because specifying the value explicitly seemed to make it clear which level the call was functioning on. |
No description provided.