Route trailing slash on mounted sub-routers #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
approved these changes
Nov 27, 2017
| if _, resp := testRequest(t, ts, "GET", "/accounts/admin", nil); resp != "accounts index" { | ||
| t.Fatalf(resp) | ||
| } | ||
| if _, resp := testRequest(t, ts, "GET", "/accounts/admin/", nil); resp != "accounts index" { |
There was a problem hiding this comment.
I think GET /accounts/admin should work for sure, being handled by GET / in the subrouter.
Do we need to support /accounts/admin/ too? I think it doesn't really hurt, and makes sense ... since "" and "/" from the sub-router perspective should be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #260
I'm not convinced yet this is the correct behaviour, but it is convenient.
Waiting to hear feedback from the community before we merge it.