Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use raw path in middleware to strip slash #799

Closed
wants to merge 1 commit into from
Closed

Use raw path in middleware to strip slash #799

wants to merge 1 commit into from

Conversation

wolfogre
Copy link

@wolfogre wolfogre commented Mar 2, 2023 •
edited
Loading

Fix #798.

Follow what has been done in other middlewares, like CleanPath

And some middlewares may have the same issue too, I don't check them.

@wolfogre wolfogre mentioned this pull request Mar 2, 2023
Closed
VojtechVitek
VojtechVitek reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wolfogre,

This contribution looks good to me. Thank you.

How does this compare to #790 btw? Would it play well together?

@wolfogre
Copy link
Author

wolfogre commented Oct 8, 2024

I believe #790 has a better implementation to fix this. It also checks r.URL.RawPath before r.URL.Path, which is what this PR has done. So I'm going to close this PR.

@wolfogre wolfogre closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encoded path will be decoded by middleware.StripSlashes and mismatch routers
2 participants
@wolfogre @VojtechVitek