Ensure the httplog.Options from httplog.Logger are present in middleware.LogEntry #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are.LogEntry This fixes go-chi#35 as the httplog.Options#JSON now causes the log entry to not be pretty printed to stderr if set to true.
|
This works but the test requires the changes from #38 |
|
This is similar to #34 but changing only the cause of the bug and adding a test for it. Credit really goes to @peter-teslenko for fixing #35 |
stefansaasen
changed the title
This was referenced Apr 16, 2024
Merged
|
With #34 merged the bug has been fixed. This PR has a test for the change but not sure if that is worth adding. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #35 as the httplog.Options#JSON now causes the log entry to not be pretty printed to stderr if set to true.