Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove init register pattern #11

Merged
merged 2 commits into from
Nov 10, 2019
Merged

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Nov 10, 2019

No description provided.

@go-clog go-clog deleted a comment from codecov bot Nov 10, 2019
@go-clog go-clog deleted a comment from codecov bot Nov 10, 2019
@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

Merging #11 into master will decrease coverage by 1%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   67.89%   66.89%   -1.01%     
==========================================
  Files           7        7              
  Lines         433      447      +14     
==========================================
+ Hits          294      299       +5     
- Misses        128      137       +9     
  Partials       11       11
Impacted Files Coverage Δ
clog.go 88.57% <ø> (ø) ⬆️
console.go 78.26% <75%> (-5.08%) ⬇️
logger.go 88.17% <82.35%> (-1.63%) ⬇️
slack.go 72.88% <88.88%> (-1.2%) ⬇️
discord.go 72.09% <88.88%> (-1.08%) ⬇️
file.go 34.61% <88.88%> (+1.01%) ⬆️

@unknwon unknwon merged commit e927c36 into master Nov 10, 2019
@unknwon unknwon deleted the jc/remove-init-register-pattern branch November 10, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant