Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: delete outdated files after rotate #15

Merged
merged 1 commit into from
Jan 31, 2020
Merged

file: delete outdated files after rotate #15

merged 1 commit into from
Jan 31, 2020

Conversation

jsfaint
Copy link
Contributor

@jsfaint jsfaint commented Dec 18, 2019

This PR will fix issue #14
I have tested it already, it works well for me

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #15 into master will decrease coverage by 0.29%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master      #15     +/-   ##
=========================================
- Coverage   66.89%   66.59%   -0.3%     
=========================================
  Files           7        7             
  Lines         447      449      +2     
=========================================
  Hits          299      299             
- Misses        137      139      +2     
  Partials       11       11
Impacted Files Coverage Δ
file.go 34.09% <0%> (-0.53%) ⬇️

@unknwon
Copy link
Member

unknwon commented Jan 31, 2020

Thank you! Sorry for being so late... it's strange I never knew this PR exists 😳

@unknwon unknwon changed the title Delete outdated files after rotate file: delete outdated files after rotate Jan 31, 2020
@unknwon unknwon merged commit f79ab8a into go-clog:master Jan 31, 2020
@jsfaint
Copy link
Contributor Author

jsfaint commented Jan 31, 2020

Thank you! Sorry for being so late... it's strange I never knew this PR exists 😳

haha. It's OK. thanks for your great libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants