Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process not terminating #19

Closed
ghost opened this issue Jul 18, 2018 · 4 comments
Closed

Process not terminating #19

ghost opened this issue Jul 18, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 18, 2018

I am on Mac.

When I run the streaking example but calling my long running server ( a golang server ), and I use control c key my golang server is still hanging around..

??

Something in the example is missing for the streaking example ?

Or my golang server is not sending out the correct termination signals ?

@daniel-nichter
Copy link
Member

Difficult to say without seeing the code. Also not clear on what you're doing: are you CTRL-C'ing the server or the streaming client?

@ghost
Copy link
Author

ghost commented Jul 21, 2018 via email

@daniel-nichter
Copy link
Member

If you're CTRL-C'ing the server and it's not stopping, then it's most likely a bug in the server code. Without doing a full debug of that code, it looks like the issue would be in https://github.com/jirenius/resgate/blob/master/service/service.go#L110 or one of the functions it calls. I would debug and make sure https://github.com/jirenius/resgate/blob/master/main.go#L197 does, in fact, return and everything that should be stopped is stopped.

@daniel-nichter
Copy link
Member

It's been awhile, so I'll close this issue for now. If you find a reproducible bug, please re-open. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant