Delete unique tag alongside RemoveByTag #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunmahishi
previously approved these changes
May 19, 2021
Co-authored-by: Arjun Mahishi <arjun.mahishi@gmail.com>
arjunmahishi
approved these changes
May 19, 2021
There was a problem hiding this comment.
LGTM!
@JohnRoesler or @Streppel can have a look once and merge it
JohnRoesler
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Currently, when you create jobs with unique tags and delete by tag afterwards, the unique tag is deleted. This leads to a unique tag constraint when adding a new job with the previous unique tag.
This PR solves this issue by deleting the unique tag alongside the
RemoveByTagmethod.List any changes that modify/break current functionality
Delete unique tag in
RemoveByTagHave you included tests for your changes?
yes
Notes
Thanks for maintaining this library. We're planning to integrate it for a major feature and the tagging functionality is a game-changer :)