Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic err job create before set behaviour. #234

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Fix panic err job create before set behaviour. #234

merged 4 commits into from
Sep 13, 2021

Conversation

denizzengin
Copy link

What does this do?

fix panic error and can be set behaviour before new job created.

Which issue(s) does this PR fix/relate to?

Resolve #230

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@denizzengin
Copy link
Author

hi @JohnRoesler ,
What do you think above solution ?
it's more generic than my first solution.

scheduler.go Outdated Show resolved Hide resolved
scheduler.go Outdated Show resolved Hide resolved
scheduler.go Outdated Show resolved Hide resolved
@JohnRoesler JohnRoesler merged commit 971b91f into go-co-op:main Sep 13, 2021
@JohnRoesler
Copy link
Contributor

@denizzengin thanks for the contribution! ❤️

@denizzengin denizzengin deleted the fix_new_job_panic_err branch September 13, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Scheduling a job and calling get current job before every/cron panics
2 participants