fix RunNow() when calling from a job returned by Jobs() #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
commented
Feb 2, 2024
Comment on lines
+457
to
+461
| in.id, | ||
| in.name, | ||
| slices.Clone(in.tags), | ||
| s.jobOutRequestCh, | ||
| s.runJobRequestCh, |
There was a problem hiding this comment.
switched this to not used named struct parameters so a future build will break if a new field is added to job but not populated here
JohnRoesler
commented
Feb 2, 2024
Comment on lines
+1532
to
+1535
| _, err := s.NewJob(tt.j, NewTask(tt.fun), tt.opts...) | ||
| require.NoError(t, err) | ||
|
|
||
| j := s.Jobs()[0] |
There was a problem hiding this comment.
updating this test to validate the exact behavior seen in the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Jobs() needs to return the run now channel in order to enable jobs to use RunNow
Which issue(s) does this PR fix/relate to?
resolves #667
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes