Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal refactoring of JobOption constructor, clock moved to exec #761

Merged
merged 1 commit into from
Jul 18, 2024
Merged

internal refactoring of JobOption constructor, clock moved to exec #761

merged 1 commit into from
Jul 18, 2024

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

  • refactors the JobOption constructor (and subs, StartAt, e.g.) to take a time.Time to remove usage of time.Now and replace with the clock's time.Now
  • move's the clock object to the exec struct for future use cases
  • lint clean up

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler JohnRoesler merged commit 256265f into v2 Jul 18, 2024
4 checks passed
@JohnRoesler JohnRoesler deleted the refactoring branch July 18, 2024 16:32
rbroggi pushed a commit to rbroggi/gocron that referenced this pull request Sep 19, 2024
@JohnRoesler
internal refactoring of JobOption constructor, clock moved to exec (g…
67648ff 
…o-co-op#761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohnRoesler