Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: underef gives false positives for multiple levels of indirection #94

Merged
merged 2 commits into from
May 14, 2018
Merged

lint: underef gives false positives for multiple levels of indirection #94

merged 2 commits into from
May 14, 2018

Conversation

fexolm
Copy link
Contributor

@fexolm fexolm commented May 14, 2018

fix #68

@fexolm fexolm requested a review from quasilyte May 14, 2018 17:35
@fexolm
Copy link
Contributor Author

fexolm commented May 14, 2018

also fixes #46

quasilyte
quasilyte approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@quasilyte quasilyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fexolm fexolm merged commit 9430ca2 into master May 14, 2018
@fexolm fexolm deleted the underef_fix branch May 14, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lint: underef gives false positives for multiple levels of indirection
2 participants
@fexolm @quasilyte