Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #198

Closed
frederich opened this issue Aug 5, 2015 · 58 comments
Closed

Windows support #198

frederich opened this issue Aug 5, 2015 · 58 comments

Comments

@frederich
Copy link

Add support for Windows.

@ip
Copy link

ip commented Aug 22, 2015

Also need this

@jpop32
Copy link

jpop32 commented Aug 24, 2015

Is there any work being done on this? With support for delve recently pulled into IntelliJ plugin this suddenly became a very interesting issue.

@derekparker
Copy link
Member

Not that I am aware of, at the moment.

If somebody would be willing to take on this endeavor that would be great,
otherwise I will write the port as soon as I can.
On Mon, Aug 24, 2015 at 7:08 AM Jovica Popovic notifications@github.com
wrote:

Is there any work being done on this? With support for delve recently
pulled into IntelliJ plugin this suddenly became a very interesting issue.


Reply to this email directly or view it on GitHub
https://github.com/derekparker/delve/issues/198#issuecomment-134218235.

@0x003e
Copy link

0x003e commented Sep 7, 2015

+1

8 similar comments
@knightyzj
Copy link

+1

@thanzen
Copy link

thanzen commented Sep 10, 2015

+1

@MikeGCV
Copy link

MikeGCV commented Sep 10, 2015

+1

@anidotnet
Copy link

+1

@yourchanges
Copy link

+1

@yaoshuangxi
Copy link

+1

@papa-stiflera
Copy link

+1

@sekeroth
Copy link

+1

@delaneyj
Copy link

I'm well aware this doesn't help but... +1

@ip
Copy link

ip commented Sep 16, 2015

Crowd of typical Windows users :D

@luiscarrasco
Copy link

G+1

@mrz1836
Copy link

mrz1836 commented Sep 17, 2015

+1

@ioanvapi
Copy link

+5 (... & some friends)

@christianpv
Copy link

+1

4 similar comments
@Ekranos
Copy link

Ekranos commented Sep 22, 2015

+1

@mantzas
Copy link

mantzas commented Sep 22, 2015

+1

@hatuan
Copy link

hatuan commented Sep 25, 2015

+1

@dimchansky
Copy link

+1

@yougg
Copy link

yougg commented Oct 4, 2015

+1024

@ZloyDyadka
Copy link

+1

@LitixThomas
Copy link

+4096

@walfud
Copy link

walfud commented Oct 11, 2015

+1

@chai2010
Copy link

+(1/0)

@akevinbailey
Copy link

+1

@seriallink
Copy link

Although I use Linux at home, I have no choice at work. So +1

@JoshZA
Copy link

JoshZA commented Dec 5, 2015

👍

@derekparker derekparker added the os label Jan 2, 2016
lukehoban added a commit to lukehoban/delve that referenced this issue Jan 18, 2016
lukehoban added a commit to lukehoban/delve that referenced this issue Jan 19, 2016
lukehoban added a commit to lukehoban/delve that referenced this issue Jan 19, 2016
lukehoban added a commit to lukehoban/delve that referenced this issue Jan 19, 2016
lukehoban added a commit to lukehoban/delve that referenced this issue Jan 21, 2016
lukehoban added a commit to lukehoban/delve that referenced this issue Jan 21, 2016
@ghost
Copy link

ghost commented Jan 22, 2016

Is there a writeup on the steps to build this? I switched to the Windows branch and tried to build as per readme, but got:

$ GO15VENDOREXPERIMENT=1 make install
go install -ldflags="-X main.Build=bddb712a6b8e408d3da78e1f2d399661f074f7e9" github.com/derekparker/delve/cmd/dlv
# github.com/derekparker/delve/proc
c:\dev\projects\_go\src\github.com\derekparker\delve\proc\proc.go:52: undefined: OSProcessDetails
c:\dev\projects\_go\src\github.com\derekparker\delve\proc\threads.go:21: undefined: unix.WaitStatus
Makefile:44: recipe for target 'install' failed
make: *** [install] Error 2

@asampal
Copy link

asampal commented Jan 22, 2016

Or, if building on Windows is still not doable, does the CI box produce usable artifacts for this? I didn't see any at a glance.

@AnthonyPoschen
Copy link

You Should look at the wip windows pull request.

@asampal
Copy link

asampal commented Jan 22, 2016

I did, but how does that help? I tried what @joelday and@kolkov mentioned they did and still get output similar to the above.

@AnthonyPoschen
Copy link

It's 4am for me. I'm sure if you write your exact issue someone will help you. #276 should have enough info to setup a build.

Just make sure lukehoban's windows branch is in the correct folder and not the master branch. Since the above errors I saw when I did not use the windows build.

@kolkov
Copy link

kolkov commented Jan 23, 2016

@asampal @asampaleanu I do not use vendor and GO15VENDOREXPERIMENT=1.
I only go to cmd/dlv folder and run go build. May be it's wrong? but it's worked for me!
https://groups.google.com/forum/#!topic/golang-nuts/ECpAVEpa7yw - plugin for IDEA and last dvl.exe
http://kolkov.ru/share/dlv/delve.rar
Make sure that you use WINDOWS branch! Same errors I had before switching to windows.

@asampal
Copy link

asampal commented Jan 23, 2016

@kolkov, I am using the Windows branch on @lukehoban's repo, but as you'll note above, the complaint comes from @derekparker's source. Thanks for the pre-built binary you provided in the Google group. I'd still like to be able to build this myself, though.

@zanven42 all I'm doing is cloning @lukehoban's repo, switching to the Windows branch, and following the build steps there for Linux, but using Bash under MSYS2/MingW-w64. I had to manually go get the dependencies as mentioned in the readme since without that I was getting errors about them being missing.

@lukehoban
Copy link
Contributor

@asampal The errors you are seeing suggest that you haven't correctly checked out the windows branch from my fork. Both of those errors refer to things which are in master but not in the PR branch.

@asampal
Copy link

asampal commented Jan 23, 2016

@lukehoban does this look OK?

adi@serenity MINGW64 /c/dev/projects/_go/src/github.com/lukehoban
$ git clone https://github.com/lukehoban/delve.git
Cloning into 'delve'...
remote: Counting objects: 5804, done.
remote: Compressing objects: 100% (33/33), done.
remote: Total 5804 (delta 8), reused 0 (delta 0), pack-reused 5771
Receiving objects: 100% (5804/5804), 9.52 MiB | 3.03 MiB/s, done.
Resolving deltas: 100% (3608/3608), done.
Checking connectivity... done.

adi@serenity MINGW64 /c/dev/projects/_go/src/github.com/lukehoban
$ cd delve

adi@serenity MINGW64 /c/dev/projects/_go/src/github.com/lukehoban/delve
$ git checkout -b origin/windows
Switched to a new branch 'origin/windows'

adi@serenity MINGW64 /c/dev/projects/_go/src/github.com/lukehoban/delve
$ git status
On branch origin/windows
nothing to commit, working directory clean

adi@serenity MINGW64 /c/dev/projects/_go/src/github.com/lukehoban/delve
$ GO15VENDOREXPERIMENT=1 make install
go get -u github.com/peterh/liner
go get -u github.com/spf13/cobra
go get -u golang.org/x/sys/unix
go get -u github.com/davecheney/profile
go get -u gopkg.in/yaml.v2
go install  github.com/derekparker/delve/cmd/dlv
# github.com/derekparker/delve/proc
c:\dev\projects\_go\src\github.com\derekparker\delve\proc\proc.go:52: undefined: OSProcessDetails
c:\dev\projects\_go\src\github.com\derekparker\delve\proc\threads.go:21: undefined: unix.WaitStatus
Makefile:42: recipe for target 'install' failed
make: *** [install] Error 2

@AnthonyPoschen
Copy link

Put lukehobans files in Derek's folder and replace them. You are still building master and not the windows build.

@kolkov
Copy link

kolkov commented Jan 23, 2016

@asampal
image
image
image
image

@lukehoban
Copy link
Contributor

Windows support is now available in master. ⚡

I've updated the wiki with build instructions for Windows: https://github.com/derekparker/delve/wiki/Building#windows.

There are a handful of known issues and not yet implemented features - which are being tracked in https://github.com/derekparker/delve/issues/363. But generally speaking, the majority of Delve's functionality should be working on Windows.

Going forward, if you see issues uniquely on Windows, feel free to mention me in issue reports and I can help take a look.

@hatuan
Copy link

hatuan commented Jan 24, 2016

I have a problem with delve on WebStorm 11.0.3, breakpoint in HelloController it don't work.

/*------ main.go ---*/
router := routers.InitRoutes()
router.PathPrefix("/").Handler(http.StripPrefix("/", fileHandler))

n := negroni.Classic()
n.UseHandler(router)
/*--- route.go ---*/
func InitRoutes() *mux.Router {
    router := mux.NewRouter()
    router = SetAuthenticationRoutes(router)
    router = SetHelloRoutes(router)

    return router
}
func SetHelloRoutes(router *mux.Router) *mux.Router {
    router.Handle("/api/hello",
        negroni.New(
            negroni.HandlerFunc(authentication.RequireTokenAuthentication),
            negroni.HandlerFunc(controllers.HelloController),
        )).Methods("GET")

    return router
}
/*---- hello_controller.go ---*/
func HelloController(w http.ResponseWriter, r *http.Request, next http.HandlerFunc) {
    w.Write([]byte("Hello, World!"))
}

If I set breakpoint in HelloController it don't work.

Breakpoint in HelloController work on Visual Studio Code.

@kolkov
Copy link

kolkov commented Jan 24, 2016

@hatuan what version of plugin you are using?

@hatuan
Copy link

hatuan commented Jan 24, 2016

@kolkov I have used both Go-0.10.SNAPSHOT.zip (http://kolkov.ru/share/dlv/dalve.rar) and update 0.10.607

@kolkov
Copy link

kolkov commented Jan 24, 2016

go-lang-plugin-org/go-lang-idea-plugin#1922 (comment)
I think it's not a delve issue. It's plugin issue.
24 янв. 2016 г. 1:11 PM пользователь "Tuan Hoang Anh" <
notifications@github.com> написал:

@kolkov https://github.com/kolkov I have used both Go-0.10.SNAPSHOT.zip
(http://kolkov.ru/share/dlv/dalve.rar) and update 0.10.607


Reply to this email directly or view it on GitHub
https://github.com/derekparker/delve/issues/198#issuecomment-174276633.

abner-chenc pushed a commit to loongson/delve that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests