Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/dap: dlv config <param> should print, not reset value without an explicit parameter #2890

Closed
polinasok opened this issue Feb 3, 2022 · 2 comments
Closed

service/dap: dlv config <param> should print, not reset value without an explicit parameter #2890

polinasok opened this issue Feb 3, 2022 · 2 comments
Labels
area/dap

Comments

@polinasok
Copy link
Collaborator

A very intuitive way to look up a config value is to run dlv config <param>. This worked as expected with dlv@v1.7.3.
image
But with dlv@v1.8.0 and dlv@latest the same command tries to reset the value, which works only in some cases
image
I think we should go back to previous consistent and intuitive behavior. Resetting values should be an explicit action. We don't want users to accidentally reset anything when they try to simply look up what they are or remind themselves what the syntax is. And there should be an easy way to look up an existing setting without having to dig through the full list of configuration values with dlv config -list.

@suzmue
@polinasok polinasok changed the title service/dap: dlv config <param> should print, but not reset the value without an explicit parameter service/dap: dlv config <param> should print, not reset value without an explicit parameter Feb 3, 2022
@polinasok
Copy link
Collaborator Author

I just remember that this now works:

dlv config -list showGlobalVariables
showGlobalVariables	false

It's not ideal because -list appears before the parameter, so switching back and force between setting and looking up values requires changes in the middle of the command, which can get quite tedious.

@aarzilli aarzilli mentioned this issue Apr 17, 2023
Merged
aarzilli added a commit to aarzilli/delve that referenced this issue Apr 17, 2023
@aarzilli
*: misc improvements to config command and substitute-path rules
229e43e 
A series of interconnected changes to both the terminal command
'config', DAP command 'dlv config', quality of life improvements to how
substitute-path works, and better documentation.

- Let 'config substitute-path' show the current substitute path rules
- Add a -clear command to 'config substitute-path'
- Support 'config-debug-info-directories'
- rewrite SubstitutePath to be platform independent (see below)
- document path substitution more

Regarding the rewrite of SubstitutePath: the previous version used
runtime.GOOS and filepath.IsAbs to determine which filepath separator to use
and if matching should be case insensitive. This is wrong in all situations
where the client and server run on different OSes, when examining core files
and when cross-compilation is involved.

The new version of SubstitutePath checks the rules and the input path to
determine if Windows is involved in the process, if it looks like it is it
switches to case-insensitive matching. It uses a lax version of
filepath.IsAbs to determine if a path is absolute and tries to avoid having
to select a path separator as much as possible

Fixes go-delve#2891, go-delve#2890, go-delve#2889, go-delve#3179, go-delve#3332
aarzilli added a commit to aarzilli/delve that referenced this issue Apr 26, 2023
@aarzilli
*: misc improvements to config command and substitute-path rules
f58b258 
A series of interconnected changes to both the terminal command
'config', DAP command 'dlv config', quality of life improvements to how
substitute-path works, and better documentation.

- Let 'config substitute-path' show the current substitute path rules
- Add a -clear command to 'config substitute-path'
- Support 'config-debug-info-directories'
- rewrite SubstitutePath to be platform independent (see below)
- document path substitution more

Regarding the rewrite of SubstitutePath: the previous version used
runtime.GOOS and filepath.IsAbs to determine which filepath separator to use
and if matching should be case insensitive. This is wrong in all situations
where the client and server run on different OSes, when examining core files
and when cross-compilation is involved.

The new version of SubstitutePath checks the rules and the input path to
determine if Windows is involved in the process, if it looks like it is it
switches to case-insensitive matching. It uses a lax version of
filepath.IsAbs to determine if a path is absolute and tries to avoid having
to select a path separator as much as possible

Fixes go-delve#2891, go-delve#2890, go-delve#2889, go-delve#3179, go-delve#3332, go-delve#3343
aarzilli added a commit to aarzilli/delve that referenced this issue Apr 26, 2023
@aarzilli
*: misc improvements to config command and substitute-path rules
528ad46 
A series of interconnected changes to both the terminal command
'config', DAP command 'dlv config', quality of life improvements to how
substitute-path works, and better documentation.

- Let 'config substitute-path' show the current substitute path rules
- Add a -clear command to 'config substitute-path'
- Support 'config-debug-info-directories'
- rewrite SubstitutePath to be platform independent (see below)
- document path substitution more

Regarding the rewrite of SubstitutePath: the previous version used
runtime.GOOS and filepath.IsAbs to determine which filepath separator to use
and if matching should be case insensitive. This is wrong in all situations
where the client and server run on different OSes, when examining core files
and when cross-compilation is involved.

The new version of SubstitutePath checks the rules and the input path to
determine if Windows is involved in the process, if it looks like it is it
switches to case-insensitive matching. It uses a lax version of
filepath.IsAbs to determine if a path is absolute and tries to avoid having
to select a path separator as much as possible

Fixes go-delve#2891, go-delve#2890, go-delve#2889, go-delve#3179, go-delve#3332, go-delve#3343
aarzilli added a commit to aarzilli/delve that referenced this issue Apr 28, 2023
@aarzilli
*: misc improvements to config command and substitute-path rules
909335b 
A series of interconnected changes to both the terminal command
'config', DAP command 'dlv config', quality of life improvements to how
substitute-path works, and better documentation.

- Let 'config substitute-path' show the current substitute path rules
- Add a -clear command to 'config substitute-path'
- Support 'config-debug-info-directories'
- rewrite SubstitutePath to be platform independent (see below)
- document path substitution more

Regarding the rewrite of SubstitutePath: the previous version used
runtime.GOOS and filepath.IsAbs to determine which filepath separator to use
and if matching should be case insensitive. This is wrong in all situations
where the client and server run on different OSes, when examining core files
and when cross-compilation is involved.

The new version of SubstitutePath checks the rules and the input path to
determine if Windows is involved in the process, if it looks like it is it
switches to case-insensitive matching. It uses a lax version of
filepath.IsAbs to determine if a path is absolute and tries to avoid having
to select a path separator as much as possible

Fixes go-delve#2891, go-delve#2890, go-delve#2889, go-delve#3179, go-delve#3332, go-delve#3343
derekparker pushed a commit that referenced this issue May 2, 2023
@aarzilli
*: misc improvements to config command and substitute-path rules (#3335)
13ad7dc 
A series of interconnected changes to both the terminal command
'config', DAP command 'dlv config', quality of life improvements to how
substitute-path works, and better documentation.

- Let 'config substitute-path' show the current substitute path rules
- Add a -clear command to 'config substitute-path'
- Support 'config-debug-info-directories'
- rewrite SubstitutePath to be platform independent (see below)
- document path substitution more

Regarding the rewrite of SubstitutePath: the previous version used
runtime.GOOS and filepath.IsAbs to determine which filepath separator to use
and if matching should be case insensitive. This is wrong in all situations
where the client and server run on different OSes, when examining core files
and when cross-compilation is involved.

The new version of SubstitutePath checks the rules and the input path to
determine if Windows is involved in the process, if it looks like it is it
switches to case-insensitive matching. It uses a lax version of
filepath.IsAbs to determine if a path is absolute and tries to avoid having
to select a path separator as much as possible

Fixes #2891, #2890, #2889, #3179, #3332, #3343
@aarzilli
Copy link
Member

aarzilli commented May 2, 2023

Fixed by 13ad7dc

@aarzilli aarzilli closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aarzilli @derekparker @polinasok