Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix same-user check and add flag to disable it #1839

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Fix same-user check and add flag to disable it #1839

merged 2 commits into from
Feb 11, 2020

Conversation

aarzilli
Copy link
Member 

cmd: add flag to disable same-user check

Fixes #1835

service: also search IPv6 connections when checking user

When checking if the user is allowed to connect to this Delve instance
also search IPv6 connections even though the local address is IPv4.

Fixes #1835

@aarzilli
service: also search IPv6 connections when checking user
7861e6f 
When checking if the user is allowed to connect to this Delve instance
also search IPv6 connections even though the local address is IPv4.

Fixes go-delve#1835
@aarzilli
cmd: add flag to disable same-user check
6816e7c 
Fixes go-delve#1835
@aarzilli
Copy link
Member Author

cc @nd @stapelberg

@aarzilli aarzilli changed the title cmd: add flag to disable same-user check Fix same-user check and add flag to disable it Jan 20, 2020
@stapelberg
Copy link
Contributor

stapelberg commented Jan 20, 2020 •
edited
Loading

Not sure the IPv6-checking of IPv4-mapped addresses is really required—AIUI, Go doesn’t set up sockets that way.

Looks like GoLand uses IPv4-mapped addresses: #1835 (comment)

@nd
Copy link
Contributor

nd commented Jan 20, 2020

Thanks for the option! Tested without it - connection works fine as well.

@nd
Copy link
Contributor

nd commented Feb 11, 2020

Would it be possible to include this fix into 1.4.0 release?

derekparker
derekparker approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 81a8608 into go-delve:master Feb 11, 2020
@derekparker
Copy link
Member

@nd merged, and will be included in 1.4.0.

cgxxv pushed a commit to cgxxv/delve that referenced this pull request Mar 25, 2022
@aarzilli
cmd/dlv: Fix same-user check and add flag to disable it (go-delve#1839)
7d62246 
* service: also search IPv6 connections when checking user

When checking if the user is allowed to connect to this Delve instance
also search IPv6 connections even though the local address is IPv4.

Fixes go-delve#1835

* cmd: add flag to disable same-user check

Fixes go-delve#1835
abner-chenc pushed a commit to loongson/delve that referenced this pull request Mar 1, 2024
@aarzilli @abner-chenc
cmd/dlv: Fix same-user check and add flag to disable it (go-delve#1839)
50b6b05 
* service: also search IPv6 connections when checking user

When checking if the user is allowed to connect to this Delve instance
also search IPv6 connections even though the local address is IPv4.

Fixes go-delve#1835

* cmd: add flag to disable same-user check

Fixes go-delve#1835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekparker derekparker derekparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aarzilli @stapelberg @nd @derekparker