proc: step breakpoints shouldn't hide normal breakpoints #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
reviewed
Mar 22, 2023
pkg/proc/target_exec.go
Outdated
| // disassembles the current instruction to figure out its destination and | ||
| // sets a breakpoint on it. | ||
| func stepIntoCallback(curthread Thread, grp *TargetGroup, p *Target) (bool, error) { | ||
| if grp.GetDirection() != Forward { |
There was a problem hiding this comment.
Couldn't we use p.recman.GetDirection() here instead of passing the group in?
When using Step on a function that has a dynamic CALL instruction we set a Step breakpoint on the call. When it is hit we determine the destination of the CALL by looking at registers, set a breakpoint there and continue. If the Step breakpoint is hit simultaneously with a normal breakpoint our Step logic will take precedence and the normal breakpoint hit will be hidden from the user. Move the Step logic to a breaklet callback so that it does not interfere with the decision to stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Step on a function that has a dynamic CALL instruction we
set a Step breakpoint on the call.
When it is hit we determine the destination of the CALL by looking at
registers, set a breakpoint there and continue.
If the Step breakpoint is hit simultaneously with a normal breakpoint
our Step logic will take precedence and the normal breakpoint hit will
be hidden from the user.
Move the Step logic to a breaklet callback so that it does not
interfere with the decision to stop.