Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dlv: logger is not closed in connect command #3367

Merged
merged 1 commit into from May 15, 2023
Merged

cmd/dlv: logger is not closed in connect command #3367

merged 1 commit into from May 15, 2023

Conversation

alexandear
Copy link
Contributor

This PR fixes os.Exit will exit, and ``defer logflags.Close()`` will not run in connectCmd.

aarzilli
aarzilli approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekparker
derekparker approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 1c9792b into go-delve:master May 15, 2023
1 of 2 checks passed
@alexandear alexandear deleted the fix-exit-after-defer branch May 16, 2023 07:21
@Kevin40481 Kevin40481 linked an issue May 18, 2023 that may be closed by this pull request
Kingbug #3368
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarzilli aarzilli aarzilli approved these changes

@derekparker derekparker derekparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kingbug
3 participants
@alexandear @aarzilli @derekparker