Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: actually run linux/386 tests on linux/386 #3392

Merged
merged 1 commit into from
May 31, 2023

Conversation

aarzilli
Copy link
Member

It seems that our linux/386 builders no longer (or never did?) use
linux/386, the i386/ubuntu:20.04 docker image has become (or always
was?) multiarchitecture and docker starterd picking (always picked?)
the amd64 version. This change should fix the problem (or break
everything).

It seems that our linux/386 builders no longer (or never did?) use
linux/386, the i386/ubuntu:20.04 docker image has become (or always
was?) multiarchitecture and docker starterd picking (always picked?)
the amd64 version. This change should fix the problem (or break
everything).
@aarzilli
Copy link
Member Author

Changes to settings.kts aren't used until merged so we have to merge and see what happens. If all linux builds break we revert.

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit cc05aa2 into go-delve:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants