terminal: ask for confirmation when using 'quit -c' with breakpoints #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
requested changes
May 31, 2023
pkg/terminal/command.go
Outdated
| numbp := 0 | ||
| for _, bp := range bps { | ||
| if bp.ID >= 0 { | ||
| numbp++ |
There was a problem hiding this comment.
We can just short circuit here, we don't care how many breakpoints are set, just that they exist.
If there are some breakpoints and the user executes 'quit -c' (quit and continue) ask for confirmation since the behavior in that case may be unexpected. Fixes go-delve#1961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are some breakpoints and the user executes 'quit -c' (quit and
continue) ask for confirmation since the behavior in that case may be
unexpected.
Fixes #1961