Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of struct pointers #39

Closed
wants to merge 1 commit into from

Conversation

epipho
Copy link
Contributor

@epipho epipho commented Jan 1, 2015

  • print structptr.member now works
  • attempting to print a pointer variable that is nil will no longer panic
  • attempting to print a member variable of a nil struct will no longer panic
  • added a bunch more tests for error conditions

{"a9.NonExistent", "nil", "int", errors.New("a9 has no member NonExistent")},
{"a8", "main.FooBar2 {Bur: 10, Baz: feh}", "main.FooBar2", nil}, // reread variable after member
{"i32", "[2]int32 [1 2]", "[2]int32", nil},
{"NonExistent", "", "", errors.New{"could not find symbol value for NonExistent"}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ending comma here, won't compile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, had that fixed locally and didn't commit. hangs head in shame

@derekparker
Copy link
Member

Thanks, if you don't mind squashing this, I'll merge it in.

@epipho
Copy link
Contributor Author

epipho commented Jan 2, 2015

Squashed.

@derekparker
Copy link
Member

Merged.

@derekparker derekparker closed this Jan 2, 2015
nclifton pushed a commit to nclifton/delve that referenced this pull request Feb 24, 2021
* track link increments hit on page hit

* publish webhook on link hit

* fix track link rpc name

* simplify track link client

* add track links param for insert mms/sms

* message id might be null?

* fix track link port for sms

* update sms find by id call in track link with account id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants