Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TravisCI support and badges #68

Closed
wants to merge 1 commit into from

Conversation

dlsniper
Copy link
Contributor

I think it would be useful to have a CI system working for PRs.

@derekparker
Copy link
Member

I definitely want some sort of CI - and Travis would work for right now. The trick is that in the future we would need more than Travis CI due to needing to test on multiple OSes and architectures.

@derekparker
Copy link
Member

@dlsniper and anyone else looking at this PR - any thoughts on this, is there an existing CI service that allows testing on multiple OSes/arches? If not I'll likely pull this in and then maybe start work on one (because we will certainly need that type of control for our CI environment for this project and it sounds fun to write).

@pnasrat
Copy link
Contributor

pnasrat commented Feb 17, 2015

I don't think so - at least not that is free for OSS use - although we could (and probably should as a base) reuse the buildlet configurations from Go itself - https://github.com/golang/build/tree/master/env

I'd say get this in as an instant fix and then look at what would be useful - the trigger/build/report cycle is probably less complex than getting good kernel/arch/distro version coverage for warts - see Rob Pike's comment https://groups.google.com/d/msg/golang-nuts/2AiVI0F3yXE/LqWRn3DSJH4J

"All that stands in the way is the writing of a lot of non-portable low-level code talking to buggy undocumented interfaces."

@derekparker
Copy link
Member

@pnasrat I agree I think this will be a good first step, especially since I think travis covers ubuntu and OS X, so depending on arch differences (should be fine but Delve does use some arch specific features atm) but that should be enough to get up and running right now.

The buildlet stuff from Go seems like it could definitely be a good starting point for a more custom solution.

However, it's exactly the sentiment in that comment that makes me want all of these other custom builders - it's essential to know if something is broken on another OS/arch due to how reliant Delve must be on those buggy/undocumented interfaces.

@dlsniper
Copy link
Contributor Author

Hi @derekparker. I'll look into it but I think if there's a service that does this for money you can sure ask them if they are willing to give you a free version for this project only ;-) If not, maybe ask the Go team itself?

@derekparker
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants