Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unroll string decoder #23

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

tdakkota
Copy link
Member

name                              old time/op    new time/op    delta
Decoder_StrBytes/Plain/2b-4         15.4ns ± 1%    15.9ns ± 5%    +3.07%  (p=0.000 n=14+14)
Decoder_StrBytes/Plain/8b-4         22.3ns ± 1%    17.1ns ± 1%   -23.41%  (p=0.000 n=15+13)
Decoder_StrBytes/Plain/16b-4        31.5ns ± 1%    20.1ns ± 1%   -36.19%  (p=0.000 n=15+15)
Decoder_StrBytes/Plain/64b-4        95.9ns ± 1%    39.2ns ± 1%   -59.14%  (p=0.000 n=15+15)
Decoder_StrBytes/Plain/128b-4        170ns ± 1%      65ns ± 1%   -61.67%  (p=0.000 n=15+14)
Decoder_StrBytes/Plain/1024b-4      1.20µs ± 1%    0.43µs ± 2%   -63.99%  (p=0.000 n=13+15)
Decoder_StrBytes/Escaped/2b-4       17.7ns ± 1%    17.4ns ± 1%    -1.88%  (p=0.000 n=15+14)
Decoder_StrBytes/Escaped/8b-4       31.6ns ± 1%    20.0ns ± 1%   -36.51%  (p=0.000 n=14+14)
Decoder_StrBytes/Escaped/16b-4      49.9ns ± 0%    26.6ns ± 2%   -46.73%  (p=0.000 n=12+13)
Decoder_StrBytes/Escaped/64b-4       169ns ± 0%      65ns ± 2%   -61.45%  (p=0.000 n=14+13)
Decoder_StrBytes/Escaped/128b-4      317ns ± 0%     122ns ± 2%   -61.47%  (p=0.000 n=14+13)
Decoder_StrBytes/Escaped/1024b-4    2.38µs ± 1%    0.85µs ± 2%   -64.35%  (p=0.000 n=14+15)

name                              old speed      new speed      delta
Decoder_StrBytes/Plain/2b-4        259MB/s ± 1%   252MB/s ± 5%    -2.94%  (p=0.000 n=14+14)
Decoder_StrBytes/Plain/8b-4        448MB/s ± 1%   585MB/s ± 1%   +30.57%  (p=0.000 n=15+13)
Decoder_StrBytes/Plain/16b-4       571MB/s ± 1%   894MB/s ± 1%   +56.72%  (p=0.000 n=15+15)
Decoder_StrBytes/Plain/64b-4       688MB/s ± 1%  1685MB/s ± 1%  +144.71%  (p=0.000 n=15+15)
Decoder_StrBytes/Plain/128b-4      767MB/s ± 1%  2000MB/s ± 1%  +160.90%  (p=0.000 n=15+14)
Decoder_StrBytes/Plain/1024b-4     853MB/s ± 1%  2368MB/s ± 2%  +177.68%  (p=0.000 n=13+15)
Decoder_StrBytes/Escaped/2b-4      339MB/s ± 1%   345MB/s ± 1%    +1.91%  (p=0.000 n=15+14)
Decoder_StrBytes/Escaped/8b-4      570MB/s ± 1%   898MB/s ± 1%   +57.50%  (p=0.000 n=14+14)
Decoder_StrBytes/Escaped/16b-4     681MB/s ± 0%  1279MB/s ± 2%   +87.76%  (p=0.000 n=12+13)
Decoder_StrBytes/Escaped/64b-4     768MB/s ± 0%  1992MB/s ± 2%  +159.42%  (p=0.000 n=14+13)
Decoder_StrBytes/Escaped/128b-4    815MB/s ± 0%  2114MB/s ± 2%  +159.54%  (p=0.000 n=14+13)
Decoder_StrBytes/Escaped/1024b-4   861MB/s ± 1%  2414MB/s ± 2%  +180.53%  (p=0.000 n=14+15)
name                  old time/op    new time/op    delta
OTEL_Decode/Decode-4    1.25µs ± 2%    1.10µs ± 1%  -12.24%  (p=0.000 n=14+15)

name                  old speed      new speed      delta
OTEL_Decode/Decode-4   414MB/s ± 2%   472MB/s ± 1%  +13.95%  (p=0.000 n=14+15)

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #23 (ff01633) into main (dcb5603) will decrease coverage by 0.06%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   99.11%   99.04%   -0.07%     
==========================================
  Files          29       29              
  Lines        2158     2210      +52     
==========================================
+ Hits         2139     2189      +50     
- Misses         15       17       +2     
  Partials        4        4              
Impacted Files Coverage Δ
dec_str.go 99.04% <97.05%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb5603...ff01633. Read the comment docs.

@ernado ernado self-assigned this Jan 16, 2022
@ernado ernado merged commit 5c8b11f into go-faster:main Jan 16, 2022
@tdakkota tdakkota deleted the feat/unroll-string-decoding branch January 16, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants