Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve float decoding layout, add more float benchmarks #41

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

tdakkota
Copy link
Member

name                                old time/op    new time/op    delta
Decoder_Float64/floats.json-4         3.17µs ± 4%    2.96µs ± 1%   -6.66%  (p=0.000 n=23+25)
Decoder_Float64/slow_floats.json-4    21.2µs ± 2%    20.8µs ± 2%   -1.93%  (p=0.000 n=23+25)
Decoder_Float64/integers.json-4       4.32µs ± 2%    3.85µs ± 4%  -10.92%  (p=0.000 n=24+25)

name                                old time/op    new time/op    delta
Decoder_Float64/floats.json-4         3.17µs ± 4%    2.96µs ± 1%   -6.66%  (p=0.000 n=23+25)
Decoder_Float64/slow_floats.json-4    21.2µs ± 2%    20.8µs ± 2%   -1.93%  (p=0.000 n=23+25)
Decoder_Float64/integers.json-4       4.32µs ± 2%    3.85µs ± 4%  -10.92%  (p=0.000 n=24+25)
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #41 (9f27e28) into main (e09ad96) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2307      2307           
=========================================
  Hits          2307      2307           
Impacted Files Coverage Δ
dec_float.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09ad96...9f27e28. Read the comment docs.

@tdakkota tdakkota merged commit 8bfec7d into go-faster:main Mar 18, 2022
@tdakkota tdakkota deleted the test/add-more-float-benchmarks branch March 18, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant