Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce streaming Raw memory usage #55

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

Benchstat result:
```
name                  old time/op    new time/op    delta
Decoder_Raw/Reader-4     499ns ± 2%     453ns ± 3%   -9.18%  (p=0.000 n=23+25)

name                  old speed      new speed      delta
Decoder_Raw/Reader-4  86.3MB/s ± 2%  95.0MB/s ± 3%  +10.13%  (p=0.000 n=23+25)

name                  old alloc/op   new alloc/op   delta
Decoder_Raw/Reader-4      144B ± 0%       96B ± 0%  -33.33%  (p=0.000 n=25+25)

name                  old allocs/op  new allocs/op  delta
Decoder_Raw/Reader-4      3.00 ± 0%      2.00 ± 0%  -33.33%  (p=0.000 n=25+25)
```
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #55 (2f19fa7) into main (6ce2694) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2392      2406   +14     
=========================================
+ Hits          2392      2406   +14     
Impacted Files Coverage Δ
dec_raw.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce2694...2f19fa7. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review June 20, 2022 08:35
@ernado ernado merged commit e1801fb into go-faster:main Jun 20, 2022
@tdakkota tdakkota deleted the feat/optimize-reader-raw branch June 20, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants