Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SHA256 for SSH signing #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use SHA256 for SSH signing #24

wants to merge 1 commit into from

Conversation

42wim
Copy link
Contributor

@42wim 42wim commented Dec 25, 2021

When using the SSH Agent signers we need to use a wrapper to actually
allow signing with SHA256.

When using the SSH Agent signers we need to use a wrapper to actually
allow signing with SHA256.
@cjslep
Copy link
Member

cjslep commented Jan 19, 2022

Hi, very sorry for the delay. I see the referenced issue: golang/go#37278

Is marked closed. Is this change still needed? I have no problem with a wrapper for SSH Agent signers. I am just not entirely a big fan of enabling MD4/MD5.

@42wim
Copy link
Contributor Author

42wim commented Jan 19, 2022

I'm not doing anything with md4/md5, this PR enables SHA256 for ssh signing instead of SHA1.
If you look at the diff I just remove a comment, I'm not changing anything wrt md4/md5

@42wim
Copy link
Contributor Author

42wim commented Feb 12, 2022

@cjslep please let me know if there's anything not clear

@42wim
Copy link
Contributor Author

42wim commented May 29, 2022

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants