chore: add justification for disabled markdownlint rules #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhitt
force-pushed
the
chore/markdownlint-comments
branch
3 times, most recently
from
b7de53e
to
7a04cc3
Compare
dylanhitt
force-pushed
the
chore/markdownlint-comments
branch
from
7a04cc3
to
ca898a4
Compare
ccoVeille
approved these changes
Jul 8, 2024
EwenQuim
reviewed
Jul 8, 2024
EwenQuim
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
@ccoVeille thank you for the suggestions. The practice actually uncovered that the CI wasn't actually testing anything 😅. I appreciate your time here.
Let me know how this looks!
Cheers