Add Git Notes #15
Merged
Add Git Notes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
reviewed
Nov 25, 2023
fixtures.go
Outdated
| @@ -189,6 +189,9 @@ var fixtures = Fixtures{{ | |||
| }, { | |||
| Tags: []string{"packfile", "pack-sha256"}, | |||
| PackfileHash: "407497645643e18a7ba56c6132603f167fe9c51c00361ee0c81d74a8f55d0ee2", | |||
| }, { | |||
| Tags: []string{"packfile", "Notes"}, | |||
There was a problem hiding this comment.
All the tags are lowercased, so it would be good to be keep it consistent:
Suggested change
| Tags: []string{"packfile", "Notes"}, | |
| Tags: []string{"packfile", "notes"}, |
There was a problem hiding this comment.
Do I need to regenerate the tag in the git repo?
There was a problem hiding this comment.
It is now lowercase
pjbgf
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For go-git/go-git#928
Hope I got everything right.