This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
Add GPG payload to commit information if present #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sapk
changed the title
|
This one is finish and is enough to validate a commit. For the payload (commit messages except signature), i think that it's more simple and secure to keep the full data and not try to reconstruct it after but i am open to suggestion ^^. |
|
LGTM |
|
LGTM |
bkcsoft
reviewed
Apr 18, 2017
| // CommitGPGSignature represents a git commit signature part. | ||
| type CommitGPGSignature struct { | ||
| Signature string | ||
| Payload string //TODO check if can be reconstruct from the rest of commit information to not have duplicate data |
There was a problem hiding this comment.
@sapk Easiest way would be to have a cache-layer for GPG-sigs somewhere, just not just where 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on : https://github.com/git/git/blob/3bc53220cb2dcf709f7a027a3f526befd021d858/commit.c#L1128
I have to do further testing to determine if the struct CommitGPGSignature could not be replace by a simple string representing directly CommitGPGSignature.Signature. Since payload can maybe re-created from the rest of data in Commit struct.
If we don't care about duplicate of data at this stage it will simplify treatment after since payload and signature (+ public key from keystore in gitea) is only needed to verify the signed commit. https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/gpg-interface.c#L204