Improve make PR (force build and help message) #10178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
added
type/miscellaneous
skip-changelog
jolheiser
reviewed
Feb 7, 2020
GiteaBot
added
the
lgtm/need 2
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
guillep2k
reviewed
Feb 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #10178 +/- ##
==========================================
- Coverage 43.42% 43.41% -0.01%
==========================================
Files 576 576
Lines 79642 79642
==========================================
- Hits 34585 34578 -7
- Misses 40782 40791 +9
+ Partials 4275 4273 -2
Continue to review full report at Codecov.
|
6543
reviewed
Feb 7, 2020
| @@ -120,6 +120,7 @@ help: | |||
| @echo " - vet examines Go source code and reports suspicious constructs" | |||
| @echo " - test run unit test" | |||
| @echo " - test-sqlite run integration test for sqlite" | |||
| @echo " - pr#<index> build and start gitea from a PR with integration test data loaded" | |||
guillep2k
approved these changes
Feb 7, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Feb 7, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
make prtomake helpand force build assets before launch (mostly to update ui)