-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong AppSubUrl in multiple templates #10447
Fixed wrong AppSubUrl in multiple templates #10447
Conversation
CI failure looks unrelated ... |
@6543 I replaced the other occurences of $.AppSubURL in the mentioned files. |
Codecov Report
@@ Coverage Diff @@
## master #10447 +/- ##
==========================================
+ Coverage 43.68% 43.69% +0.01%
==========================================
Files 586 586
Lines 81389 81389
==========================================
+ Hits 35552 35566 +14
+ Misses 41433 41424 -9
+ Partials 4404 4399 -5
Continue to review full report at Codecov.
|
Ping lgtm |
When run behind a reverse proxy in a sub-path, an oauth2 application can be added, but not edited.
This is because the $.AppSubURL in the form-action of the edit template does not include the sub-path. I replaced it with AppSubUrl, which includes it.
PS: The template files \templates\explore\code.tmpl and \templates\repo\settings\lfs_locks.tmpl also utilize $.AppSubURL, which might fail in this configuration.