Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid mailing users that have explicitly unwatched an issue #10475

Merged
merged 7 commits into from
Feb 27, 2020
Merged

Avoid mailing users that have explicitly unwatched an issue #10475

merged 7 commits into from
Feb 27, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 26, 2020

close #8879

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2020
@6543 6543 mentioned this pull request Feb 26, 2020
Closed
@6543 6543 force-pushed the fix-8879_dont-mail-unsubscribed branch from 16bdb7d to 0951682 Compare February 26, 2020 14:53
@6543 6543 mentioned this pull request Feb 26, 2020
Closed
@lafriks lafriks added this to the 1.12.0 milestone Feb 26, 2020
@codecov-io
Copy link

codecov-io commented Feb 26, 2020 •
edited
Loading

Codecov Report

Merging #10475 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10475      +/-   ##
==========================================
- Coverage   43.71%   43.69%   -0.02%     
==========================================
  Files         586      586              
  Lines       81418    81418              
==========================================
- Hits        35592    35579      -13     
- Misses      41419    41429      +10     
- Partials     4407     4410       +3
Impacted Files Coverage Δ
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
services/pull/check.go 52.43% <0%> (-3.05%) ⬇️
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
modules/indexer/issues/indexer.go 57.53% <0%> (-1.37%) ⬇️
models/notification.go 63.55% <0%> (-0.85%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (ø) ⬆️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
modules/git/repo.go 47.7% <0%> (+0.91%) ⬆️
modules/git/utils.go 70.14% <0%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e773424...cada3f6. Read the comment docs.

guillep2k
guillep2k approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit. Otherwise LGTM.

services/mailer/mail_issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2020
@guillep2k
Copy link
Member

I'm sorry for having introduced this bug. 😔

@6543 @guillep2k
back to normal
5eac8d6 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@6543
Copy link
Member Author

6543 commented Feb 27, 2020

@guillep2k I think this bug was there before you changed some code ...

@6543 6543 mentioned this pull request Feb 27, 2020
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2020
@zeripath zeripath merged commit a924a90 into go-gitea:master Feb 27, 2020
@zeripath
Copy link
Contributor

Please send backport

@6543 6543 deleted the fix-8879_dont-mail-unsubscribed branch February 27, 2020 11:39
@6543 6543 mentioned this pull request Feb 27, 2020
Merged
@6543
Copy link
Member Author

6543 commented Feb 27, 2020

backport: #10500

@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 27, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 27, 2020
@6543
[BugFix] Avoid mailing explicit unwatched (go-gitea#10475)
6abf5ad 
Avoid mailing explicit unwatched
jolheiser pushed a commit that referenced this pull request Feb 27, 2020
@6543
[BugFix] Avoid mailing explicit unwatched (#10475) (#10500)
50f2e90 
* [BugFix] Avoid mailing explicit unwatched (#10475)
@zeripath zeripath changed the title [BugFix] Avoid mailing explicit unwatched Avoid mailing users that have explicitly unwatched an issue Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
6 participants
@6543 @codecov-io @guillep2k @zeripath @lafriks @GiteaBot