Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: unknwon/cae move to taged version #10521

Merged
merged 3 commits into from
Feb 28, 2020
Merged

vendor: unknwon/cae move to taged version #10521

merged 3 commits into from
Feb 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 28, 2020

as title

@guillep2k guillep2k changed the title vendor: unknown/cae move to taged version vendor: unknwon/cae move to taged version Feb 28, 2020
@guillep2k guillep2k added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 28, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Feb 28, 2020
@codecov-io
Copy link

codecov-io commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #10521 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10521      +/-   ##
==========================================
- Coverage   43.68%   43.64%   -0.05%     
==========================================
  Files         586      586              
  Lines       81521    81521              
==========================================
- Hits        35614    35581      -33     
- Misses      41493    41534      +41     
+ Partials     4414     4406       -8
Impacted Files Coverage Δ
services/pull/check.go 31.09% <0%> (-18.91%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
models/pull.go 41.82% <0%> (-0.56%) ⬇️
models/error.go 28.71% <0%> (-0.52%) ⬇️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
models/gpg_key.go 53.95% <0%> (+0.52%) ⬆️
modules/indexer/issues/indexer.go 58.9% <0%> (+1.36%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18f2a7...1ca295f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@zeripath zeripath merged commit ae4eaf0 into go-gitea:master Feb 28, 2020
@6543 6543 deleted the update-unknown-cae branch February 28, 2020 14:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-io @zeripath @guillep2k @GiteaBot