Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update github.com/yuin/goldmark to v1.1.24 #10551

Merged
merged 1 commit into from
Mar 1, 2020
Merged

vendor: update github.com/yuin/goldmark to v1.1.24 #10551

merged 1 commit into from
Mar 1, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Mar 1, 2020

Fix #10542

@sapk sapk added the type/bug label Mar 1, 2020
@sapk sapk added this to the 1.12.0 milestone Mar 1, 2020
@sapk
Copy link
Member Author

sapk commented Mar 1, 2020 •
edited
Loading

I will block set wip because it seems to have updated too much files in the vendor folder

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2020
@sapk sapk added the pr/wip This PR is not ready for review label Mar 1, 2020
@sapk
Copy link
Member Author

sapk commented Mar 1, 2020 •
edited
Loading

It seems that vendor are not uptodate with go.mod but they should have failed previously on CI.
I was just using an old version of go that manage go mod differently 😑

@sapk sapk removed the pr/wip This PR is not ready for review label Mar 1, 2020
@sapk
Copy link
Member Author

sapk commented Mar 1, 2020 •
edited
Loading

This PR is good for review now.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2020
@6543
Copy link
Member

6543 commented Mar 1, 2020

ping lgtm

@lafriks lafriks merged commit f9d34b2 into go-gitea:master Mar 1, 2020
@sapk sapk deleted the updt-goldmark branch March 1, 2020 17:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Markdown issue for bold
5 participants
@sapk @6543 @silverwind @lafriks @GiteaBot