Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore checkbox rendering and prevent poor sanitization of spans #11277

Merged
merged 6 commits into from
May 3, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 2, 2020

Fixes #11276

Also fixes a bug with preview page - a $ appears to have gone missing.

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 2, 2020
@zeripath zeripath added this to the 1.12.0 milestone May 2, 2020
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 2, 2020
@6543
Copy link
Member

6543 commented May 2, 2020

sanitization ... | I'll test it later :)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-io
Copy link

Codecov Report

Merging #11277 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11277      +/-   ##
==========================================
+ Coverage   43.79%   43.81%   +0.01%     
==========================================
  Files         607      607              
  Lines       86876    86877       +1     
==========================================
+ Hits        38045    38061      +16     
+ Misses      44133    44122      -11     
+ Partials     4698     4694       -4     
Impacted Files Coverage Δ
modules/markup/sanitizer.go 93.47% <100.00%> (+0.07%) ⬆️
services/pull/check.go 35.36% <0.00%> (-17.08%) ⬇️
modules/indexer/stats/db.go 50.00% <0.00%> (-9.38%) ⬇️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
models/pull.go 51.42% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 33.39% <0.00%> (+0.19%) ⬆️
models/issue.go 52.41% <0.00%> (+0.46%) ⬆️
modules/notification/webhook/webhook.go 43.59% <0.00%> (+0.58%) ⬆️
modules/markup/markdown/ast.go 12.24% <0.00%> (+12.24%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f8308...317b919. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit ce66ca7 into go-gitea:master May 3, 2020
@zeripath zeripath deleted the refix-checkboxes branch May 3, 2020 20:52
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…-gitea#11277)

* Add test

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Restore checkbox rendering and prevent poor sanitization of spans

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Also fix preview context

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Also fix preview context

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emojify PR broke task list checkbox styling
6 participants