Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API allow to create closed milestones #11745

Merged
merged 12 commits into from
Jun 9, 2020
Merged

API allow to create closed milestones #11745

merged 12 commits into from
Jun 9, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 3, 2020

as title

@6543
Copy link
Member Author

6543 commented Jun 3, 2020

usefull for https://gitea.com/gitea/go-sdk/issues/356

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 3, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2020
@zeripath zeripath added modifies/api This PR adds API routes or modifies them lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 4, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 6, 2020
@zeripath
Copy link
Contributor

zeripath commented Jun 7, 2020

make lg-tm work

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 9, 2020
@6543
Copy link
Member Author

6543 commented Jun 9, 2020

🚀

@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 1ac4618 into go-gitea:master Jun 9, 2020
@6543 6543 deleted the api_create-closed-milestones branch June 9, 2020 22:12
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543 @lafriks @techknowlogick
API allow to create closed milestones (go-gitea#11745)
d18205c 
* API allow to create closed milestones

* set CloseDate too

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @zeripath @techknowlogick @lafriks @GiteaBot