Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make help' #12509

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fix 'make help' #12509

merged 1 commit into from
Aug 17, 2020

Conversation

silverwind
Copy link
Member

These targets are actually using plural names, fix help output for them.

Ref: #12352

These targets are actually using plural names, fix help output for them.

Ref: go-gitea#12352
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 17, 2020
@techknowlogick techknowlogick added modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12509 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12509      +/-   ##
==========================================
- Coverage   43.53%   43.53%   -0.01%     
==========================================
  Files         637      637              
  Lines       70825    70825              
==========================================
- Hits        30835    30831       -4     
- Misses      34989    34991       +2     
- Partials     5001     5003       +2     
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/log/event.go 59.43% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cabd56...2e2a000. Read the comment docs.

@techknowlogick techknowlogick merged commit 51463a0 into go-gitea:master Aug 17, 2020
@silverwind silverwind deleted the fixhelp branch August 17, 2020 17:29
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants