Set utf8mb4 as the default charset on MySQL if CHARSET is unset #12563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL in its infinite wisdom determines that UTF8 does not mean UTF8. Our install scripts know about this and will set CHARSET to utf8mb4 if we users choose this but... users who do not explicitly set this variable will default to utf8mb3 without knowing it. This PR changes the unset CHARSET value to utf8mb4 if users choose to use mysql. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
pr/breaking
silverwind
approved these changes
Aug 22, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
removed
the
pr/breaking
|
as this just makes the code match the documentation I'm removing the breaking label and adding the bug label |
|
Technically that makes it backportable too. |
lunny
approved these changes
Aug 22, 2020
GiteaBot
added
lgtm/done
|
I don't think we should back port this one. |
Codecov Report
@@ Coverage Diff @@
## master #12563 +/- ##
=======================================
Coverage 43.42% 43.43%
=======================================
Files 643 643
Lines 71157 71159 +2
=======================================
+ Hits 30903 30907 +4
+ Misses 35243 35240 -3
- Partials 5011 5012 +1
Continue to review full report at Codecov.
|
zeripath
deleted the
change-default-charset-for-mysql-if-charset-is-not-set
branch
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL in its infinite wisdom determines that UTF8 does not
mean UTF8. Our install scripts know about this and will set
CHARSET to utf8mb4 if we users choose this but... users who
do not explicitly set this variable will default to utf8mb3
without knowing it.
This PR changes the unset CHARSET value to utf8mb4 if users
choose to use mysql.
Signed-off-by: Andrew Thornton art27@cantab.net