Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a small nit #13074

Merged
merged 1 commit into from
Oct 8, 2020
Merged

fix a small nit #13074

merged 1 commit into from
Oct 8, 2020

Conversation

a1012112796
Copy link
Member

No description provided.

@a1012112796
fix a small nit
89ce19e 
Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 8, 2020
@lafriks lafriks added this to the 1.13.0 milestone Oct 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #13074 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13074   +/-   ##
=======================================
  Coverage   42.61%   42.62%           
=======================================
  Files         672      672           
  Lines       73787    73787           
=======================================
+ Hits        31445    31449    +4     
+ Misses      37250    37247    -3     
+ Partials     5092     5091    -1
Impacted Files Coverage Δ
modules/setting/git.go 66.66% <0.00%> (ø)
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
services/pull/check.go 48.46% <0.00%> (+0.76%) ⬆️
modules/indexer/stats/db.go 69.56% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144fa5a...89ce19e. Read the comment docs.

@techknowlogick techknowlogick merged commit a5ba818 into go-gitea:master Oct 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@a1012112796 @codecov-io @techknowlogick @lafriks @zeripath @GiteaBot