Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow secondary actions for review comments #13394

Closed
MGChecker opened this issue Nov 2, 2020 · 6 comments
Closed

Allow secondary actions for review comments #13394

MGChecker opened this issue Nov 2, 2020 · 6 comments
Labels
topic/pr Issues related to pull requests

Comments

@MGChecker
Copy link

Currently, review comments are missing the quote, edit, delete and reaction buttons present for other comments. It would be nice if these could be added.

@silverwind
Copy link
Member

Reaction button is fixed on latest master. As for other differences, those two boxes use different templates and they are bound to drift apart in functionality because of that, we should unify them to a single template.

@MathJoDE
Copy link

I'm absolutely new to Go and new to this repo, but am basically interested in tackling this.

Could someone kindly point me to the relevant templates/code points where to make this change?

@lafriks
Copy link
Member

lafriks commented Jan 23, 2021

Already fixed in #14339

@lafriks lafriks closed this as completed Jan 23, 2021
@MathJoDE
Copy link

(Assuming this PR is already live on try.gitea.io)

It would really appreciate to also have this action menu in the "header comment" (upper comment in the screenshot) of a review, and not only at the inline comments.

Screenshot_20210123_163124

@MGChecker
Copy link
Author

@lafriks Please reopen issue – as pointed out by @MathJoDE, this has not been resolved by this PR.

@MGChecker
Copy link
Author

This has been realized by now.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/pr Issues related to pull requests
Projects
None yet
Development

No branches or pull requests

5 participants