When reinitialising DBConfig reset the database use flags #13796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One perennial issue is users running the install page, changing the database dialect and then suffering with issues This PR simply resets all of the database.Use flags on initDBConfig. This should prevent this issue from occuring. Fix go-gitea#13788 Fix go-gitea#5480 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Dec 2, 2020
GiteaBot
added
the
lgtm/need 1
mrsdizzie
approved these changes
Dec 2, 2020
GiteaBot
added
lgtm/done
|
🚀 |
Codecov Report
@@ Coverage Diff @@
## master #13796 +/- ##
==========================================
- Coverage 42.29% 42.12% -0.17%
==========================================
Files 708 708
Lines 77123 77127 +4
==========================================
- Hits 32617 32488 -129
- Misses 39147 39291 +144
+ Partials 5359 5348 -11
Continue to review full report at Codecov.
|
|
@zeripath please send backport :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 3, 2020
…3796) Backport go-gitea#13796 One perennial issue is users running the install page, changing the database dialect and then suffering with issues This PR simply resets all of the database.Use flags on initDBConfig. This should prevent this issue from occuring. Fix go-gitea#13788 Fix go-gitea#5480 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
6543
pushed a commit
that referenced
this pull request
Dec 3, 2020
…13811) Backport #13796 One perennial issue is users running the install page, changing the database dialect and then suffering with issues This PR simply resets all of the database.Use flags on initDBConfig. This should prevent this issue from occuring. Fix #13788 Fix #5480 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One perennial issue is users running the install page,
changing the database dialect and then suffering with issues
This PR simply resets all of the database.Use flags on
initDBConfig. This should prevent this issue from occuring.
Fix #13788
Fix #5480
Signed-off-by: Andrew Thornton art27@cantab.net