Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] pull request field Mergeable = ture but not aproved #13879

Open
6543 opened this issue Dec 6, 2020 · 2 comments
Open

[api] pull request field Mergeable = ture but not aproved #13879

6543 opened this issue Dec 6, 2020 · 2 comments
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@6543
Copy link
Member

6543 commented Dec 6, 2020

either add a check to IsMerged witch check branch protection or add an extra field witch show if a pull is realy ready to merge (required ci passed & required reviews)

gitea version: v1.13.0

@6543 6543 added type/proposal The new feature has not been accepted yet but needs to be discussed first. modifies/api This PR adds API routes or modifies them labels Dec 6, 2020
@6543 6543 changed the title [api] pull request status IsMergable = ture but not aproved [api] pull request field Mergeable = ture but not aproved Dec 6, 2020
@noerw
Copy link
Member

noerw commented Dec 6, 2020

I think restricting the current IsMergeable field is much easier to understand for API consumers

@bilderbuchi
Copy link

I think this should be a separate field, and the "mergeable" field should remain scoped on the Git-mergeability.
Otherwise, e.g. CI services will have a hard time judging when to start a CI run on a PR update -- right now it gets held off if there is a merge conflict (i.e. mergeable is false).
If protection rule results etc. would get folded into the same flag, CI would not run as long as e.g. there are not enough reviews, which will probably not come as long as CI has not run, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants