Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search and Diff CSS enhancements #14050

Merged
merged 7 commits into from
Dec 20, 2020
Merged

Search and Diff CSS enhancements #14050

merged 7 commits into from
Dec 20, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 18, 2020 •
edited
Loading

  • Use flexbox for language stats
  • Improve labels and code boxes on repo and code search
  • Use flexbox on diff header and improve suppressed diff text
  • Add dedicated color for diff expander
  • Multiple diff improvements, smaller header, always show triangle, image centering

Screen Shot 2020-12-18 at 16 23 30

Screen Shot 2020-12-18 at 16 35 38

Screen Shot 2020-12-18 at 23 03 17

Screen Shot 2020-12-19 at 01 29 45

Screen Shot 2020-12-19 at 01 29 37

Screen Shot 2020-12-19 at 01 26 05

@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 18, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 18, 2020
@silverwind
Search and Diff CSS enhancements
56116eb 
- Use flexbox for language stats
- Improve labels and code boxes on repo and code search
- Use flexbox on diff header and improve suppressed diff text
- Add dedicated color for diff expander
@silverwind
Copy link
Member Author

Think I'll look into rendering "File diff supressed" in the body of the diff file box, but otherwise I'm quite happy already with the changes.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit b4f8da5 into go-gitea:master Dec 20, 2020
@silverwind silverwind deleted the csstweaks17 branch December 21, 2020 17:20
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @lunny @lafriks @GiteaBot