-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize Co-Authored-By / Reviewed-By strings #14097
Conversation
On unrelated note, we should perform check against noreply email to avoid situation where |
Codecov Report
@@ Coverage Diff @@
## master #14097 +/- ##
==========================================
+ Coverage 42.33% 42.35% +0.01%
==========================================
Files 726 726
Lines 77799 77799
==========================================
+ Hits 32940 32950 +10
+ Misses 39445 39443 -2
+ Partials 5414 5406 -8
Continue to review full report at Codecov.
|
But it seems Github use |
There seems to be both usages happening in the wild. Either one is fine with me, so long it's consistent across all places. |
Seems the lowercase variant is more common as far as git itself is concerned: |
Switched to lowercase variant |
Make sure all these strings use same capitalization style.