Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StatDir and replace com.StatDir #14099

Merged
merged 6 commits into from
Dec 21, 2020
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 21, 2020

As title.

@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 21, 2020
modules/util/path.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 21, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 21, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 21, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #14099 (06349c7) into master (addd424) will decrease coverage by 0.00%.
The diff coverage is 40.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14099      +/-   ##
==========================================
- Coverage   42.34%   42.33%   -0.01%     
==========================================
  Files         726      726              
  Lines       77741    77788      +47     
==========================================
+ Hits        32918    32931      +13     
- Misses      39421    39446      +25     
- Partials     5402     5411       +9     
Impacted Files Coverage Δ
models/repo.go 51.89% <0.00%> (ø)
modules/util/path.go 55.69% <40.42%> (-22.43%) ⬇️
modules/options/dynamic.go 60.78% <50.00%> (ø)
modules/templates/dynamic.go 56.14% <50.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 42.35% <0.00%> (-0.51%) ⬇️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fd899...752de1c. Read the comment docs.

@lunny lunny merged commit acd5e5a into go-gitea:master Dec 21, 2020
@lunny lunny deleted the lunny/statDir branch December 21, 2020 23:41
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants