-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix manifest encoding #14114
Fix manifest encoding #14114
Conversation
ce78fe2
to
40ba741
Compare
500e22c
to
922a939
Compare
Ok fixed that and Firefox is now satisfied as well. |
09f663e
to
3f25059
Compare
The previous URL encoding would encode spaces to '+' for the app name which is incorrect. Use base64 encoding instead which does not have such issues.
3f25059
to
3100bc9
Compare
Seems it does not handle the case of |
Added a new |
I'm so glad it's not just me that golangci-lint beats around the head... |
Its insistance on comments is infuriating. Closely followed by it not liking |
The previous URL encoding would encode spaces to '+' for the app name (e.g.
Gitea:+Git+with+a+cup+of+tea
) which is incorrect. Use base64 encoding instead which does not have such issues. Also, use JSON escaping which is sufficient for the data.